fix(selectors): resolve env var references at design time for selector context#3446
Conversation
…r context
Selectors now resolve {{ENV_VAR}} references before building context and
returning dependency values to consumers, enabling env-var-based credentials
(e.g. {{SLACK_BOT_TOKEN}}) to work with selector dropdowns.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview
Written by Cursor Bugbot for commit 04d1f03. Configure here. |
...kflowId]/components/panel/components/editor/components/sub-block/hooks/use-selector-setup.ts
Outdated
Show resolved
Hide resolved
Greptile SummaryThis PR fixes env-var-based credentials (e.g.
Confidence Score: 4/5
Last reviewed commit: 04d1f03 |
...kflowId]/components/panel/components/editor/components/sub-block/hooks/use-selector-setup.ts
Outdated
Show resolved
Hide resolved
…o context - Fall back to undefined instead of raw template string when env var is missing from store, so the null-check in the context loop discards it - Use resolvedDetailId in query cache key so React Query refetches when the underlying env var value changes Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@cursor review |
|
@greptile |
...kflowId]/components/panel/components/editor/components/sub-block/hooks/use-selector-setup.ts
Outdated
Show resolved
Hide resolved
Align use-selector-setup.ts with use-selector-query.ts by using || instead of ?? so empty-string env var values are treated as unset. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@cursor review |
|
@greptile |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Summary
{{ENV_VAR}}references before building context and returning dependency values to consumers{{SLACK_BOT_TOKEN}}) to work with selector dropdownsuseSelectorSetupdependency values anduseSelectorOptionDetaildetailIdType of Change
Testing
Tested manually
Checklist